lkml.org 
[lkml]   [2019]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] xhci: Convert xhci_handshake() to use readl_poll_timeout()
On Thu, Feb 7, 2019 at 12:27 AM Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
>
> On 07.02.2019 02:03, Andrey Smirnov wrote:
> > Xhci_handshake() implements the algorithm already captured by
> > readl_poll_timeout(). Convert the former to use the latter to avoid
> > repetition.
>
> readl_poll_timeout() doesn't really work here as it might sleep.
>
> iopoll.h:
>
> /**
> * readx_poll_timeout - Periodically poll an address until a condition is met or a timeout occurs
> *
> ...
> * Returns 0 on success and -ETIMEDOUT upon a timeout. In either
> * case, the last read value at @addr is stored in @val. Must not
> * be called from atomic context if sleep_us or timeout_us are used.
>
> -Mathias

Shoot, missed this part. Will change to readl_poll_timeout_atomic() in v2.

Thanks,
Andrey Smirnov

\
 
 \ /
  Last update: 2019-02-07 22:05    [W:0.174 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site