Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 7 Feb 2019 12:52:09 -0800 | Subject | Re: [PATCH 5/5] ARM: warn if divided syntax assembler is used |
| |
On Thu, Feb 7, 2019 at 1:46 AM Stefan Agner <stefan@agner.ch> wrote: > > Remove the -mno-warn-deprecated assembler flag to make sure the GNU > assembler warns in case non-unified syntax is used. > > Signed-off-by: Stefan Agner <stefan@agner.ch>
Good idea, thanks for unifying the syntax.
> --- > arch/arm/Makefile | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index a0d08a3c9d33..811498e16673 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -112,9 +112,6 @@ ifeq ($(CONFIG_ARM_UNWIND),y) > CFLAGS_ABI +=-funwind-tables > endif > > -# Accept old syntax despite ".syntax unified" > -AFLAGS_NOWARN :=$(call as-option,-Wa$(comma)-mno-warn-deprecated,-Wa$(comma)-W) > -
Shouldn't you also remove the references to the now gone AFLAGS_NOWARN on lines 120 AND 127?
> ifeq ($(CONFIG_THUMB2_KERNEL),y) > AFLAGS_AUTOIT :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it) > CFLAGS_ISA :=-mthumb $(AFLAGS_AUTOIT) $(AFLAGS_NOWARN) > -- > 2.20.1 >
-- Thanks, ~Nick Desaulniers
| |