Messages in this thread | | | Date | Thu, 7 Feb 2019 12:36:54 -0500 | From | Dennis Zhou <> | Subject | Re: [PATCH v2 00/12] btrfs: add zstd compression level support |
| |
On Thu, Feb 07, 2019 at 05:59:26PM +0100, David Sterba wrote: > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote: > > Dennis Zhou (12): > > btrfs: add helpers for compression type and level > > btrfs: rename workspaces_list to workspace_manager > > btrfs: manage heuristic workspace as index 0 > > btrfs: unify compression ops with workspace_manager > > btrfs: add helper methods for workspace manager init and cleanup > > btrfs: add compression interface in (get/put)_workspace() > > btrfs: move to fn pointers for get/put workspaces > > btrfs: plumb level through the compression interface > > btrfs: change set_level() to bound the level passed in > > btrfs: zstd use the passed through level instead of default > > btrfs: make zstd memory requirements monotonic > > btrfs: add zstd compression level support > > The patchset has been added to msic-next, scheduled for 5.1. I've left > out the changes to warn on wrong level, so currently it falls back to > the default. I don't want to make a last minute change of that sort, so > this needs to go as a separate patch.
Regarding the bug report from Dan, do you want me to send you a patch for it on top of the topic branch or do you mind fixing the missing:
unsigned int level = 0;
> > I also did a last pass through all patches and made some trivial changes > like reformatting comments or minor style updates, nothing functional. > The inter-branch diff can be found at > https://github.com/kdave/btrfs-devel/compare/ext/dzhou/compr-workspaces-v2..kdave:ext/dzhou/compr-workspaces > > The feature should be ready to use, though as mentioned before some fine > tuning might be necessary to make the memory requirements more > efficient. The code could be simplified or cleaned up now that there are > 3 compressors, at this point stabilization fixes are preferred. > > Thanks.
Thanks David! Dennis
| |