Messages in this thread | | | Date | Thu, 7 Feb 2019 10:05:37 -0500 | From | Joel Fernandes <> | Subject | Re: [PATCH 1/3] sched/wait: use freezable_schedule when possible |
| |
On Thu, Feb 07, 2019 at 12:30:50AM +0100, Hugo Lefeuvre wrote: > Hi Joel, > > > I'm curious did you try the freezing process and see if pointless wakeups are > > reduced? That would be an added bonus if you did. > > I'm currently testing these changes. I hope to be able to come back with > more concrete results soon. > > Also, I just noticed that the third patch removes a necessary #include > <linux/freezer.h>. I will submit an updated version tomorrow. > > Thanks for the review!
Sure, add these test results to the patch as well showing reduced wakeups.
I would say submit the freezable_schedule as a single separate patch independent of the vsoc series since it can go in separately, and also benefits other things than vsoc.
Also CC Rafael (power maintainer) on it.
Thank you!
- Joel
| |