Messages in this thread | | | Date | Thu, 7 Feb 2019 12:11:46 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 4/5] phy: tegra: xusb: Add support for power supplies |
| |
On Tue, Feb 05, 2019 at 06:25:04PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 28/01/19 1:30 PM, Thierry Reding wrote: > > On Mon, Jan 28, 2019 at 03:22:09PM +0800, jckuo wrote: > >> Hi Thierry, > >> > >> I think any non-zero return value of > >> regulator_bulk_enable()/devm_regulator_bulk_get() means error. > >> > >> Thanks, > >> > >> JC > > > > Theoretically I think only regulator_bulk_enable() could return a > > positive value, but even so it never will in practice because all of the > > regulator_enable() (see _regulator_enable()) calls will only ever return > > negative error codes. > > > > I can change this and resend if you have strong concerns about this > > possibly missing legitimate error cases. > > All error codes are negative, so this is fine IMO.
Hi Kishon,
did you have any other comments on this series? Anything keeping this from going into v5.1?
Thierry [unhandled content-type:application/pgp-signature] | |