Messages in this thread | | | Subject | Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon | From | Roberto Sassu <> | Date | Tue, 5 Feb 2019 09:08:33 +0100 |
| |
On 2/5/2019 12:40 AM, Jarkko Sakkinen wrote: > On Tue, Feb 05, 2019 at 01:31:17AM +0200, Jarkko Sakkinen wrote: >> On Mon, Feb 04, 2019 at 02:49:54PM +0100, Roberto Sassu wrote: >>> On 2/4/2019 2:37 PM, Jarkko Sakkinen wrote: >>>> Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to >>>> ST33ZP24_BUFSIZE. >>>> >>>> Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to >>>> TPM_I2C_INFINEON_BUFSIZE. >>> >>> Please also add a prefix to TPM_RETRY in tpm_i2c_nuvoton.c. >> >> Thanks, can do. > > TPM_RETRY defined in > > 32d33b29ba07 ("TPM: Retry SaveState command in suspend path") > > has nothing to do with time. I'll also remove the comment about 5 > seconds.
I'll do the same for patch 4/6.
Roberto
> The definitions for TPM_RETRY seem fairly arbitrary. Jason, could > tpm_i2c_nuvoton also use the same constant as tpm_tis_spi and TPM 1.2 > suspend, try max 50 times instead of five? > > /Jarkko >
-- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI
| |