Messages in this thread | | | Date | Tue, 5 Feb 2019 09:07:12 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v7 03/28] x86/asm/suspend: use SYM_DATA for data |
| |
On Tue, Feb 05, 2019 at 08:34:09AM +0100, Jiri Slaby wrote: > I also suggest noticing the size 0 -> 8 change ;).
Ha!
And one would think that binutils would've seen the ".quad 0" in the previous definition and do a proper size but that wouldn't have worked most likely, because before it was a simple label with alignment:
.globl saved_magic ; .p2align 4, 0x90 ; saved_magic: .quad 0
which didn't have a size probably because it didn't have an associated type (or an implicit default type or so, no clue how binutils handles labels).
VS now:
.globl saved_magic ; ; saved_magic: ; .quad 0 ; .type saved_magic STT_OBJECT ; .size saved_magic, .-saved_magic
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |