Messages in this thread | | | Subject | Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing | From | Heiner Kallweit <> | Date | Tue, 5 Feb 2019 21:23:27 +0100 |
| |
On 05.02.2019 21:18, Joe Perches wrote: > On Tue, 2019-02-05 at 12:04 -0800, Eric Dumazet wrote: >> >> On 02/05/2019 10:42 AM, Joe Perches wrote: >>> It's declared after a pointer so it is already is 2 byte aligned. >>> >>> A lot of drivers wouldn't work otherwise. >> >> Maybe these drivers are only used on arches where this does not matter. > > Possible. > > I had only grepped through the sources looking for > declarations using: > > $ git grep -B1 '\[ETH_ALEN\];' -- '*.c' | grep -A1 '\*' > > It's quite a few files in net/ too btw. > > I still think adding __align(<even#>) is unnecessary here unless > it follows something like a bool or a u8. > > I there's such a controversy, then it may be better to stay with the current code, or?
| |