Messages in this thread | | | Subject | Re: [PATCH] staging: vt6656: Use the correct style for SPDX license Identifier | From | Joe Perches <> | Date | Tue, 05 Feb 2019 10:59:40 -0800 |
| |
On Tue, 2019-02-05 at 19:44 +0100, Greg Kroah-Hartman wrote: > On Tue, Feb 05, 2019 at 08:36:24PM +0530, Nishad Kamdar wrote: > > This patch corrects the style for SPDX license Identifier in mac.h > > by using "/* */" in place of "//" as per Linux kernel licensing rules. > > Issue found by checkpatch. > > > > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com> > > --- > > drivers/staging/vt6656/mac.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/vt6656/mac.h b/drivers/staging/vt6656/mac.h > > index 94e700fcd0b6..75166020f7c6 100644 > > --- a/drivers/staging/vt6656/mac.h > > +++ b/drivers/staging/vt6656/mac.h > > @@ -1,5 +1,5 @@ > > -// SPDX-License-Identifier: GPL-2.0+ > > -/* > > +/* SPDX-License-Identifier: GPL-2.0+ > > Should really be: > > /* SPDX-License-Identifier: GPL-2.0+ */
There's a fair number of style inconsistencies in the kernel sources for that already.
~8% of the .h files that have an 'SPDX-License-Identifier:' don't use the recommended style.
$ git grep -h "SPDX-License" -- '*.h' | \ perl -p -e 's@Identifier:.*\*/*@Identifier: ... */@; s@Identifier: [^\.].*@Identifier:@' | \ sort | uniq -c | sort -rn 8506 /* SPDX-License-Identifier: ... */ 593 // SPDX-License-Identifier: 154 /* SPDX-License-Identifier: 53 * SPDX-License-Identifier: 1 * SPDX-License-Identifier: GPL-2.0 1 //SPDX-License-Identifier: 1 /* SPDX-License-Identifier: ... */
| |