Messages in this thread | | | Date | Mon, 04 Feb 2019 19:20:40 -0800 (PST) | Subject | Re: [PATCH v2 2/2] r8169: Avoid pointer aliasing | From | David Miller <> |
| |
From: Thierry Reding <thierry.reding@gmail.com> Date: Mon, 4 Feb 2019 17:42:13 +0100
> @@ -7316,7 +7325,7 @@ static int rtl_get_ether_clk(struct rtl8169_private *tp) > static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > { > const struct rtl_cfg_info *cfg = rtl_cfg_infos + ent->driver_data; > - u8 mac_addr[ETH_ALEN] __aligned(4) = {}; > + u8 mac_addr[ETH_ALEN] = {}; > struct rtl8169_private *tp;
I agree with Heiner, you have to provide at least 2 byte alignment for this buffer due to the reasons he stated.
| |