Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 5 Feb 2019 17:32:44 +0200 | Subject | Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver. |
| |
On Tue, Feb 5, 2019 at 4:21 PM Life is hard, and then you die <ronald@innovation.ch> wrote:
> > > +config KEYBOARD_APPLESPI > > > + tristate "Apple SPI keyboard and trackpad" > > > > > + depends on (X86 && ACPI && SPI) || COMPILE_TEST > > > > COMPILE_TEST more or less makes sense in conjunction with architecture selection. > > It means, your code always dependant to ACPI and SPI frameworks. > > That's why 0day complained. > > Thanks. Yes, looking at this again I realized I somewhat misunderstood > the uses of COMPILE_TEST. I've changed this now to > > depends on ACPI && SPI && (X86 || COMPILE_TEST)
Better to split like
depends on SPI && ACPI depends on X86 || COMPILE_TEST
-- With Best Regards, Andy Shevchenko
| |