Messages in this thread | | | Date | Tue, 5 Feb 2019 15:18:58 +0100 (CET) | From | Miroslav Benes <> | Subject | Re: [PATCH v2 3/4] livepatch: Proper error handling in the shadow variables selftest |
| |
On Mon, 4 Feb 2019, Petr Mladek wrote:
> Add proper error handling when allocating or getting shadow variables > in the selftest. It prevents an invalid pointer access in some situations. > It shows the good programming practice in the others. > > The error codes are just the best guess and specific for this particular > test. In general, klp_shadow_alloc() returns NULL also when the given > shadow variable has already been allocated. In addition, both > klp_shadow_alloc() and klp_shadow_get_or_alloc() might fail from > other reasons when the constructor fails. > > Note, that the error code is not really important even in the real life. > The use of shadow variables should be transparent for the original > livepatched code. > > Signed-off-by: Petr Mladek <pmladek@suse.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Miroslav
| |