lkml.org 
[lkml]   [2019]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

    Hi Andy,

    On Tue, Feb 05, 2019 at 01:45:22PM +0200, Andy Shevchenko wrote:
    > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote:
    > > The keyboard and trackpad on recent MacBook's (since 8,1) and
    > > MacBookPro's (13,* and 14,*) are attached to an SPI controller instead
    > > of USB, as previously. The higher level protocol is not publicly
    > > documented and hence has been reverse engineered. As a consequence there
    > > are still a number of unknown fields and commands. However, the known
    > > parts have been working well and received extensive testing and use.
    > >
    > > In order for this driver to work, the proper SPI drivers need to be
    > > loaded too; for MB8,1 these are spi_pxa2xx_platform and spi_pxa2xx_pci;
    > > for all others they are spi_pxa2xx_platform and intel_lpss_pci. For this
    > > reason enabling this driver in the config implies enabling the above
    > > drivers.
    >
    > > +config KEYBOARD_APPLESPI
    > > + tristate "Apple SPI keyboard and trackpad"
    >
    > > + depends on (X86 && ACPI && SPI) || COMPILE_TEST
    >
    > COMPILE_TEST more or less makes sense in conjunction with architecture selection.
    > It means, your code always dependant to ACPI and SPI frameworks.
    > That's why 0day complained.

    Thanks. Yes, looking at this again I realized I somewhat misunderstood
    the uses of COMPILE_TEST. I've changed this now to

    depends on ACPI && SPI && (X86 || COMPILE_TEST)


    Cheers,

    Ronald

    \
     
     \ /
      Last update: 2019-02-05 14:18    [W:2.643 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site