Messages in this thread | | | Date | Mon, 4 Feb 2019 06:46:32 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH v4 07/16] block: sed-opal: reuse response_get_token to decrease code duplication |
| |
On Fri, Feb 01, 2019 at 09:50:14PM +0100, David Kozub wrote: > response_get_token had already been in place, its functionality had > been duplicated within response_get_{u64,bytestring} with the same error > handling. Unify the handling by reusing response_get_token within the > other functions. > > Co-authored-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> > Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz> > Signed-off-by: Jonas Rabenstein <jonas.rabenstein@studium.uni-erlangen.de> > Reviewed-by: Scott Bauer <sbauer@plzdonthack.me>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |