lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 014/305] disable new gcc-7.1.1 warnings for now
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Linus Torvalds <torvalds@linux-foundation.org>

    commit bd664f6b3e376a8ef4990f87d08271cc2d01ba9a upstream.

    I made the mistake of upgrading my desktop to the new Fedora 26 that
    comes with gcc-7.1.1.

    There's nothing wrong per se that I've noticed, but I now have 1500
    lines of warnings, mostly from the new format-truncation warning
    triggering all over the tree.

    We use 'snprintf()' and friends in a lot of places, and often know that
    the numbers are fairly small (ie a controller index or similar), but gcc
    doesn't know that, and sees an 'int', and thinks that it could be some
    huge number. And then complains when our buffers are not able to fit
    the name for the ten millionth controller.

    These warnings aren't necessarily bad per se, and we probably want to
    look through them subsystem by subsystem, but at least during the merge
    window they just mean that I can't even see if somebody is introducing
    any *real* problems when I pull.

    So warnings disabled for now.

    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    Makefile | 3 +++
    1 file changed, 3 insertions(+)

    --- a/Makefile
    +++ b/Makefile
    @@ -617,6 +617,9 @@ include $(srctree)/arch/$(SRCARCH)/Makef

    KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,)
    KBUILD_CFLAGS += $(call cc-disable-warning,frame-address,)
    +KBUILD_CFLAGS += $(call cc-disable-warning, format-truncation)
    +KBUILD_CFLAGS += $(call cc-disable-warning, format-overflow)
    +KBUILD_CFLAGS += $(call cc-disable-warning, int-in-bool-context)

    ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE
    KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,)
    \
     
     \ /
      Last update: 2019-02-03 14:50    [W:4.060 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site