lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 121/305] ALSA: ca0106: Disable IZD on SB0570 DAC to fix audio pops
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alex Stanoev <alex@astanoev.com>

    commit ac237c28d5ac1b241d58b1b7b4b9fa10efb22fb5 upstream.

    The Creative Audigy SE (SB0570) card currently exhibits an audible pop
    whenever playback is stopped or resumed, or during silent periods of an
    audio stream. Initialise the IZD bit to the 0 to eliminate these pops.

    The Infinite Zero Detection (IZD) feature on the DAC causes the output
    to be shunted to Vcap after 2048 samples of silence. This discharges the
    AC coupling capacitor through the output and causes the aforementioned
    pop/click noise.

    The behaviour of the IZD bit is described on page 15 of the WM8768GEDS
    datasheet: "With IZD=1, applying MUTE for 1024 consecutive input samples
    will cause all outputs to be connected directly to VCAP. This also
    happens if 2048 consecutive zero input samples are applied to all 6
    channels, and IZD=0. It will be removed as soon as any channel receives
    a non-zero input". I believe the second sentence might be referring to
    IZD=1 instead of IZD=0 given the observed behaviour of the card.

    This change should make the DAC initialisation consistent with
    Creative's Windows driver, as this popping persists when initialising
    the card in Linux and soft rebooting into Windows, but is not present on
    a cold boot to Windows.

    Signed-off-by: Alex Stanoev <alex@astanoev.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/pci/ca0106/ca0106.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/pci/ca0106/ca0106.h
    +++ b/sound/pci/ca0106/ca0106.h
    @@ -582,7 +582,7 @@
    #define SPI_PL_BIT_R_R (2<<7) /* right channel = right */
    #define SPI_PL_BIT_R_C (3<<7) /* right channel = (L+R)/2 */
    #define SPI_IZD_REG 2
    -#define SPI_IZD_BIT (1<<4) /* infinite zero detect */
    +#define SPI_IZD_BIT (0<<4) /* infinite zero detect */

    #define SPI_FMT_REG 3
    #define SPI_FMT_BIT_RJ (0<<0) /* right justified mode */
    \
     
     \ /
      Last update: 2019-02-03 15:28    [W:2.497 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site