lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 150/305] ext4: avoid possible double brelse() in add_new_gdb() on error path
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit 4f32c38b4662312dd3c5f113d8bdd459887fb773 upstream.

    Fixes: b40971426a83 ("ext4: add error checking to calls to ...")
    Reported-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/resize.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/ext4/resize.c
    +++ b/fs/ext4/resize.c
    @@ -845,6 +845,7 @@ static int add_new_gdb(handle_t *handle,
    err = ext4_handle_dirty_metadata(handle, NULL, gdb_bh);
    if (unlikely(err)) {
    ext4_std_error(sb, err);
    + iloc.bh = NULL;
    goto exit_inode;
    }
    brelse(dind);
    \
     
     \ /
      Last update: 2019-02-03 15:27    [W:4.239 / U:0.800 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site