lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 081/305] spi: sh-msiof: fix deferred probing
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

    commit f34c6e6257aa477cdfe7e9bbbecd3c5648ecda69 upstream.

    Since commit 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
    platform_get_irq() can return -EPROBE_DEFER. However, the driver overrides
    an error returned by that function with -ENOENT which breaks the deferred
    probing. Propagate upstream an error code returned by platform_get_irq()
    and remove the bogus "platform" from the error message, while at it...

    Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
    Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/spi/spi-sh-msiof.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/spi/spi-sh-msiof.c
    +++ b/drivers/spi/spi-sh-msiof.c
    @@ -766,8 +766,8 @@ static int sh_msiof_spi_probe(struct pla

    i = platform_get_irq(pdev, 0);
    if (i < 0) {
    - dev_err(&pdev->dev, "cannot get platform IRQ\n");
    - ret = -ENOENT;
    + dev_err(&pdev->dev, "cannot get IRQ\n");
    + ret = i;
    goto err1;
    }

    \
     
     \ /
      Last update: 2019-02-03 15:02    [W:5.583 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site