lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 274/305] scsi: bnx2fc: Fix NULL dereference in error handling
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 9ae4f8420ed7be4b13c96600e3568c144d101a23 upstream.

    If "interface" is NULL then we can't release it and trying to will only
    lead to an Oops.

    Fixes: aea71a024914 ("[SCSI] bnx2fc: Introduce interface structure for each vlan interface")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
    @@ -2202,7 +2202,7 @@ static int _bnx2fc_create(struct net_dev
    if (!interface) {
    printk(KERN_ERR PFX "bnx2fc_interface_create failed\n");
    rc = -ENOMEM;
    - goto ifput_err;
    + goto netdev_err;
    }

    if (netdev->priv_flags & IFF_802_1Q_VLAN) {
    \
     
     \ /
      Last update: 2019-02-03 14:55    [W:2.674 / U:0.632 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site