lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 230/305] ALSA: control: fix failure to return numerical ID in 'add' event
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Sakamoto <o-takashi@sakamocchi.jp>

    commit d34890cf4113397625a6629d71749fa638a7a734 upstream.

    Currently when adding a new control, the assigned numerical ID is not
    set for event data, thus userspace applications cannot realize it just
    by event data.

    Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/core/control.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/sound/core/control.c
    +++ b/sound/core/control.c
    @@ -368,6 +368,7 @@ int snd_ctl_add(struct snd_card *card, s
    card->controls_count += kcontrol->count;
    kcontrol->id.numid = card->last_numid + 1;
    card->last_numid += kcontrol->count;
    + id = kcontrol->id;
    count = kcontrol->count;
    up_write(&card->controls_rwsem);
    for (idx = 0; idx < count; idx++, id.index++, id.numid++)
    \
     
     \ /
      Last update: 2019-02-03 14:54    [W:2.090 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site