lkml.org 
[lkml]   [2019]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 156/305] ext4: release bs.bh before re-using in ext4_xattr_block_find()
    3.16.63-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vasily Averin <vvs@virtuozzo.com>

    commit 45ae932d246f721e6584430017176cbcadfde610 upstream.

    bs.bh was taken in previous ext4_xattr_block_find() call,
    it should be released before re-using

    Fixes: 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...")
    Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/xattr.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/fs/ext4/xattr.c
    +++ b/fs/ext4/xattr.c
    @@ -1202,6 +1202,8 @@ ext4_xattr_set_handle(handle_t *handle,
    error = ext4_xattr_block_set(handle, inode, &i, &bs);
    } else if (error == -ENOSPC) {
    if (EXT4_I(inode)->i_file_acl && !bs.s.base) {
    + brelse(bs.bh);
    + bs.bh = NULL;
    error = ext4_xattr_block_find(inode, &i, &bs);
    if (error)
    goto cleanup;
    \
     
     \ /
      Last update: 2019-02-03 14:53    [W:3.072 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site