Messages in this thread | | | Date | Thu, 28 Feb 2019 14:30:41 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: af_alg - use struct_size() in sock_kfree_s() |
| |
On Thu, Feb 21, 2019 at 12:04:23PM -0600, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes, in particular in the > context in which this code is being used. > > So, change the following form: > > sizeof(*sgl) + sizeof(sgl->sg[0]) * (MAX_SGL_ENTS + 1) > > to : > > struct_size(sgl, sg, MAX_SGL_ENTS + 1) > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > crypto/af_alg.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |