Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [Intel-gfx] [PATCH] drm/i915/fence: Do not use TIMER_IRQSAFE | Date | Thu, 28 Feb 2019 10:00:07 +0000 |
| |
Quoting Sebastian Andrzej Siewior (2019-02-26 16:00:38) > On 2019-02-12 17:28:57 [+0100], To linux-kernel@vger.kernel.org wrote: > > The timer is initialized with TIMER_IRQSAFE flag. It does look like the > > timer callback requires this flag at all. Its sole purpose is to ensure > > synchronisation in the workqueue code. > > > > Remove TIMER_IRQSAFE flag because it is not required. > > ping
We call del_timer_sync from irq context, which mandates using TIMER_IRQSAFE. Failure to do so results in lots of explosions across CI -- every machine managed to hit the warning.
It may not be the best of api, but it's the only one available for the driver to use... -Chris
| |