Messages in this thread | | | From | Diana Madalina Craciun <> | Subject | Re: [PATCH] powerpc/fsl: Fix the flush of branch predictor. | Date | Wed, 27 Feb 2019 06:47:59 +0000 |
| |
Reviewed-by: Diana Craciun <diana.craciun@nxp.com>
Thanks for fixing it!
On 2/26/2019 8:18 PM, Christophe Leroy wrote: > The commit identified below adds MC_BTB_FLUSH macro only when > CONFIG_PPC_FSL_BOOK3E is defined. This results in the following error > on some configs (seen several times with kisskb randconfig_defconfig) > > arch/powerpc/kernel/exceptions-64e.S:576: Error: Unrecognized opcode: `mc_btb_flush' > make[3]: *** [scripts/Makefile.build:367: arch/powerpc/kernel/exceptions-64e.o] Error 1 > make[2]: *** [scripts/Makefile.build:492: arch/powerpc/kernel] Error 2 > make[1]: *** [Makefile:1043: arch/powerpc] Error 2 > make: *** [Makefile:152: sub-make] Error 2 > > This patch adds a blank definition of MC_BTB_FLUSH for other cases. > > Fixes: 10c5e83afd4a ("powerpc/fsl: Flush the branch predictor at each kernel entry (64bit)") > Cc: Diana Craciun <diana.craciun@nxp.com> > Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> > --- > arch/powerpc/kernel/exceptions-64e.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S > index 4549ce8d4637..49381f32b374 100644 > --- a/arch/powerpc/kernel/exceptions-64e.S > +++ b/arch/powerpc/kernel/exceptions-64e.S > @@ -338,6 +338,7 @@ ret_from_mc_except: > #define GEN_BTB_FLUSH > #define CRIT_BTB_FLUSH > #define DBG_BTB_FLUSH > +#define MC_BTB_FLUSH > #define GDBELL_BTB_FLUSH > #endif >
| |