Messages in this thread | | | Subject | Re: [PATCH v2 4/4] perf report: support record trace file decompression | From | Alexey Budankov <> | Date | Wed, 27 Feb 2019 13:56:09 +0300 |
| |
Hi,
On 25.02.2019 19:04, Alexey Budankov wrote: > > On 20.02.2019 17:48, Alexey Budankov wrote: >> >> On 12.02.2019 16:09, Jiri Olsa wrote: >>> On Mon, Feb 11, 2019 at 11:25:00PM +0300, Alexey Budankov wrote: >>>> >>>> PERF_RECORD_COMPRESSED records are decompressed from trace file into >>>> a linked list of mmaped memory regions using streaming Zstandard API. >>>> After that the regions are loaded fetching uncompressed events. When >>>> dumping raw trace (e.g., perf report -D --header) file offsets of >>>> events from compressed records are set to zero. >>>> >>>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com> >>>> --- >>>> Changes in v2: >>>> - moved compression/decompression code to session layer >>> >>> could you please add some automated test for this? >>> >>> I think it could be part of the sample synthesize test
Do you mean this one?
tools/perf/tests/sample-parsing.c
Thanks, Alexey
>>> or even new script test under tests/shell.. or anything >>> else really.. just to see that we have some clean >>> interface for this that we can test >> >> This is possible. Let's complete the code review first. >> >> Thanks, >> Alexey >> >>> >>> thanks, >>> jirka >>> >>
| |