Messages in this thread | | | Date | Tue, 26 Feb 2019 17:54:24 +0530 | From | Balakrishna Godavarthi <> | Subject | Re: [PATCH 2/3] Bluetooth: hci_qca: Move boot delay to qca_send_power_pulse() |
| |
hi Matthias,
On 2019-02-26 17:48, Balakrishna Godavarthi wrote: > On 2019-02-26 05:19, Matthias Kaehlcke wrote: >> After sending a power on pulse the driver has a delay of 100ms >> to allow the host controller to boot. Move the delay into >> qca_send_power_pulse(), since it is directly related with the >> power-on pulse. >> >> Signed-off-by: Matthias Kaehlcke <mka@chromium.org> >> --- >> drivers/bluetooth/hci_qca.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c >> index e4128774e9686..eacc108c422d0 100644 >> --- a/drivers/bluetooth/hci_qca.c >> +++ b/drivers/bluetooth/hci_qca.c >> @@ -1036,6 +1036,9 @@ static int qca_send_power_pulse(struct hci_uart >> *hu, bool on) >> usleep_range(100, 200);
[Bala] : i still doubt do we require this delay.
>> hci_uart_set_flow_control(hu, false); >> >> + if (on) >> + msleep(100); >> + >> return 0; >> } >> >> @@ -1148,9 +1151,6 @@ static int qca_wcn3990_init(struct hci_uart *hu) >> if (ret) >> return ret; >> >> - /* Wait for 100 ms for SoC to boot */ >> - msleep(100); >> - >> /* Now the device is in ready state to communicate with host. >> * To sync host with device we need to reopen port. >> * Without this, we will have RTS and CTS synchronization > > Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
-- Regards Balakrishna.
| |