lkml.org 
[lkml]   [2019]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 1/2] percpu: km: remove SMP check
    On Sun, Feb 24, 2019 at 01:13:43PM +0000, Peng Fan wrote:
    > percpu-km could only be selected by NEED_PER_CPU_KM which
    > depends on !SMP, so CONFIG_SMP will be false when choose percpu-km.
    >
    > Signed-off-by: Peng Fan <peng.fan@nxp.com>
    > ---
    > mm/percpu-km.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/percpu-km.c b/mm/percpu-km.c
    > index 0f643dc2dc65..66e5598be876 100644
    > --- a/mm/percpu-km.c
    > +++ b/mm/percpu-km.c
    > @@ -27,7 +27,7 @@
    > * chunk size is not aligned. percpu-km code will whine about it.
    > */
    >
    > -#if defined(CONFIG_SMP) && defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK)
    > +#if defined(CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK)
    > #error "contiguous percpu allocation is incompatible with paged first chunk"
    > #endif
    >
    > --
    > 2.16.4
    >

    Hi,

    I think keeping CONFIG_SMP makes this easier to remember dependencies
    rather than having to dig into the config. So this is a NACK from me.

    Thanks,
    Dennis

    \
     
     \ /
      Last update: 2019-02-25 16:14    [W:7.456 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site