lkml.org 
[lkml]   [2019]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] tmpfs: fix uninitialized return value in shmem_link
    On Mon, Feb 25, 2019 at 04:07:12PM -0800, Linus Torvalds wrote:
    > On Mon, Feb 25, 2019 at 4:03 PM Qian Cai <cai@lca.pw> wrote:
    > > >
    > > > Of course, that's just gcc. I have no idea what llvm ends up doing.
    > >
    > > Clang 7.0:
    > >
    > > # clang -O2 -S -Wall /tmp/test.c
    > > /tmp/test.c:46:6: warning: variable 'ret' is used uninitialized whenever 'if'
    > > condition is false [-Wsometimes-uninitialized]
    >
    > Ok, good.
    >
    > Do we have any clang builds in any of the zero-day robot
    > infrastructure or something? Should we?
    >
    > And maybe this was how Dan noticed the problem in the first place? Or
    > is it just because of his eagle-eyes?

    He didn't say specifically how he found it, but I would guess he was
    running smatch...?

    --D

    > Linus

    \
     
     \ /
      Last update: 2019-02-26 01:30    [W:6.815 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site