Messages in this thread | | | Subject | Re: [PATCH V5 5/8] clk: mediatek: add MUX_GATE_FLAGS_2 | From | Stephen Boyd <> | Date | Thu, 21 Feb 2019 23:55:00 -0800 |
| |
Quoting mtk14994 (2019-02-20 18:34:11) > Dear Stephen, > > + unsigned char mux_flags; > > > > Why isn't it an unsigned long? Isn't this supposed to match the > > frameworks version of the clk flags? > > ----> it is unsigned char mux_flags ,becasuse struct clk_mux { > > .... > .... > u8 flags; > .... > } > > it is matched when use " mux->flags = mc->mux_flags;" >
Please try to not top-post.
Ok I thought it was the generic clk flags, not the mux specific flag bits. Sounds fine then, but I would sort of expect it to match the type in clk_mux then, i.e. be a u8 instead of an unsigned char (yes it's the same in the end but it looks different at a glance).
| |