lkml.org 
[lkml]   [2019]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/2] selftests/ftrace: Replace \e with \033
    On Fri, 22 Feb 2019 10:10:21 +0100
    Juerg Haefliger <juerg.haefliger@canonical.com> wrote:

    > The \e sequence character is not POSIX. Fix that by using \033 instead.
    >
    > Signed-off-by: Juerg Haefliger <juergh@canonical.com>

    This also looks good to me.

    Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

    Thank you!

    > ---
    > tools/testing/selftests/ftrace/ftracetest | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
    > index 20c9c0ad8682..136387422b00 100755
    > --- a/tools/testing/selftests/ftrace/ftracetest
    > +++ b/tools/testing/selftests/ftrace/ftracetest
    > @@ -161,10 +161,10 @@ color_green=
    > color_blue=
    > # If stdout exists and number of colors is eight or more, use them
    > if [ -t 1 -a "$ncolors" -ge 8 ]; then
    > - color_reset="\e[0m"
    > - color_red="\e[31m"
    > - color_green="\e[32m"
    > - color_blue="\e[34m"
    > + color_reset="\033[0m"
    > + color_red="\033[31m"
    > + color_green="\033[32m"
    > + color_blue="\033[34m"
    > fi
    >
    > strip_esc() {
    > --
    > 2.19.1
    >


    --
    Masami Hiramatsu <mhiramat@kernel.org>

    \
     
     \ /
      Last update: 2019-02-22 16:01    [W:4.056 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site