lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging/vboxvideo: Another FIXME item
From
Date
Hi,

On 21-02-19 16:59, Daniel Vetter wrote:
> Found while grepping around.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> ---
> drivers/staging/vboxvideo/vbox_irq.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c
> index 195484713365..89944134ea86 100644
> --- a/drivers/staging/vboxvideo/vbox_irq.c
> +++ b/drivers/staging/vboxvideo/vbox_irq.c
> @@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)
>
> validate_or_set_position_hints(vbox);
> drm_modeset_lock_all(dev);
> + /*
> + * FIXME: this needs to use drm_connector_list_iter and some real
> + * locking for the actual data it changes, not the deprecated
> + * drm_modeset_lock_all() shotgun approach.
> + */

Question, are the locking expectations from the drm's core pov (for modesetting-drivers)
*fully* (and clearly) documented somewhere?

Regards,

Hans




> list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
> vbox_conn = to_vbox_connector(connector);
>
>

\
 
 \ /
  Last update: 2019-02-21 17:41    [W:0.208 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site