Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 22 Feb 2019 00:54:47 +0900 | Subject | Re: [PATCH] bpfilter: remove extra header search paths for bpfilter_umh |
| |
On Thu, Feb 21, 2019 at 11:46 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On Thu, Jan 31, 2019 at 12:15:35PM +0900, Masahiro Yamada wrote: > > Currently, the header search paths -Itools/include and > > -Itools/include/uapi are not used. Let's drop the unused code. > > > > We can remove -I. too by fixing up one C file. > > > > This patch reintroduces the problem last fixed with commit ae40832e53c3 > ("bpfilter: fix a build err"). Seen (at least) with gcc 7.4.0, 8.2.0. > binutils version is 2.31.1. Reverting this patch fixes the problem.
Hmm. I cannot reproduce the build error with my gcc, but you are right.
I'd like to get back only 'KBUILD_HOSTCFLAGS += -Itools/include/ -Itools/include/uapi' instead of the full revert.
If David is fine with it, I can send a patch with filling commit log.
Thanks.
> Guenter > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Signed-off-by: David S. Miller <davem@davemloft.net> > > --- > > net/bpfilter/Makefile | 1 - > > net/bpfilter/main.c | 2 +- > > 2 files changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile > > index 0947ee7f70d5..5d6c7760142d 100644 > > --- a/net/bpfilter/Makefile > > +++ b/net/bpfilter/Makefile > > @@ -5,7 +5,6 @@ > > > > hostprogs-y := bpfilter_umh > > bpfilter_umh-objs := main.o > > -KBUILD_HOSTCFLAGS += -I. -Itools/include/ -Itools/include/uapi > > HOSTCC := $(CC) > > > > ifeq ($(CONFIG_BPFILTER_UMH), y) > > diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c > > index 1317f108df8a..61ce8454a88e 100644 > > --- a/net/bpfilter/main.c > > +++ b/net/bpfilter/main.c > > @@ -6,7 +6,7 @@ > > #include <sys/socket.h> > > #include <fcntl.h> > > #include <unistd.h> > > -#include "include/uapi/linux/bpf.h" > > +#include "../../include/uapi/linux/bpf.h" > > #include <asm/unistd.h> > > #include "msgfmt.h" > > > > -- > > 2.7.4
-- Best Regards
Masahiro Yamada
| |