lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 16/20] mfd: as3722: Mark PM functions as __maybe_unused
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Arnd Bergmann <arnd@arndb.de>

    commit a7b956fd38dd217dd78e3058110929f5ac914df1 upstream.

    The newly introduced as3722_i2c_suspend/resume functions are built
    unconditionally, but only used when power management is enabled,
    so we get a warning otherwise:

    drivers/mfd/as3722.c:427:12: warning: 'as3722_i2c_suspend' defined but not used [-Wunused-function]
    drivers/mfd/as3722.c:438:12: warning: 'as3722_i2c_resume' defined but not used [-Wunused-function]

    This marks them both as __maybe_unused, which avoids an ugly #ifdef
    and gives us best compile-time coverage. When they are unused, the
    compiler will silently drop the functions from its output.

    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Fixes: 35deff7eb212 ("mfd: as3722: Handle interrupts on suspend")
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Cc: Jon Hunter <jonathanh@nvidia.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mfd/as3722.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/mfd/as3722.c
    +++ b/drivers/mfd/as3722.c
    @@ -424,7 +424,7 @@ static int as3722_i2c_remove(struct i2c_
    return 0;
    }

    -static int as3722_i2c_suspend(struct device *dev)
    +static int __maybe_unused as3722_i2c_suspend(struct device *dev)
    {
    struct as3722 *as3722 = dev_get_drvdata(dev);

    @@ -435,7 +435,7 @@ static int as3722_i2c_suspend(struct dev
    return 0;
    }

    -static int as3722_i2c_resume(struct device *dev)
    +static int __maybe_unused as3722_i2c_resume(struct device *dev)
    {
    struct as3722 *as3722 = dev_get_drvdata(dev);


    \
     
     \ /
      Last update: 2019-02-21 15:51    [W:3.821 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site