Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 21 Feb 2019 15:28:26 +0200 | Subject | Re: [PATCH v5 06/10] Platform: OLPC: Add XO-1.75 EC driver |
| |
On Thu, Feb 21, 2019 at 3:22 AM Darren Hart <dvhart@infradead.org> wrote: > > On Thu, Jan 10, 2019 at 06:58:41PM +0100, Lubomir Rintel wrote: > > It's based off the driver from the OLPC kernel sources. Somewhat > > modernized and cleaned up, for better or worse. > > > > Modified to plug into the olpc-ec driver infrastructure (so that battery > > interface and debugfs could be reused) and the SPI slave framework.
> > Basically all of the above is based on the review by Andy Shevchenko. > > Andy, I am happy to merge this series - but this patch includes a lot of changes > driven by your feedback. Are you satisfied with the changes, would you like to > add your Reviewed-by?
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Open minors: - u8 vs. unsigned char in a cases when it's about command to send to HW (including unnecessary & 0xff parts) - _TIMEOUT w/o units a bit odd (perhaps _TIMEOUT_MS ?)
I think this may be addressed later on.
-- With Best Regards, Andy Shevchenko
| |