Messages in this thread | | | From | Song Liu <> | Subject | Re: [PATCH 15/17] perf bpf-event: Add missing new line into pr_debug call | Date | Thu, 21 Feb 2019 07:12:13 +0000 |
| |
> On Feb 20, 2019, at 5:25 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > From: Jiri Olsa <jolsa@kernel.org> > > Add a missing new line into pr_debug call in perf_event__synthesize_bpf_events(), > so that the error message does not screw the verbose output. > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Andi Kleen <ak@linux.intel.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Song Liu <songliubraving@fb.com> > Link: http://lkml.kernel.org/r/20190220122800.864-5-jolsa@kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Song Liu <songliubraving@fb.com>
Thanks for fixing this.
Song
> --- > tools/perf/util/bpf-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/bpf-event.c b/tools/perf/util/bpf-event.c > index 62dda96b0096..028c8ec1f62a 100644 > --- a/tools/perf/util/bpf-event.c > +++ b/tools/perf/util/bpf-event.c > @@ -233,7 +233,7 @@ int perf_event__synthesize_bpf_events(struct perf_tool *tool, > err = 0; > break; > } > - pr_debug("%s: can't get next program: %s%s", > + pr_debug("%s: can't get next program: %s%s\n", > __func__, strerror(errno), > errno == EINVAL ? " -- kernel too old?" : ""); > /* don't report error on old kernel or EPERM */ > -- > 2.19.1 >
| |