Messages in this thread | | | From | Yury Norov <> | Date | Thu, 21 Feb 2019 15:55:32 +0300 | Subject | Re: [PATCH 4/6] lib/test_bitmap: switch test_bitmap_parselist to ktime_get() |
| |
On Wed, Feb 20, 2019 at 05:20:48PM +0300, Yury Norov wrote: > On Wed, Feb 20, 2019 at 03:52:36PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 20, 2019 at 03:51:01PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 20, 2019 at 11:37:03AM +0300, Yury Norov wrote: > > > > test_bitmap_parselist currently uses get_cycles which is not > > > > implemented on some platforms, so use ktime_get() instead. > > > > > > This sounds like a fix that should go first in the series. > > > > Ah, okay, it's already first for test module. > > Perhaps Fixes tag and actually one or more examples of such architectures? > > Hi Andy, thanks for your time on it. > > Only arm, arm64, openrisc, riscv and sparc64 #define get_cycles. > So IIUC, others take stub from include/asm-generic/timex.h. > > sparc32, xtensa, m68k, um, and in some cases x86, mips and nios2 > provide zero-stubs explicitly.
I forgot about Fixes tag: Fixes: 6df0d464dbcc1a5 ("lib/test_bitmap.c: add test for bitmap_parselist()")
If it comes to v3, I'll add the tag and explanations above to the patch message.
| |