lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] printk: Pass caller information to log_store().
On Thu 2019-02-21 11:22:57, Sergey Senozhatsky wrote:
> On (02/16/19 19:59), Tetsuo Handa wrote:
> > /* insert record into the buffer, discard old ones, update heads */
> > -static int log_store(int facility, int level,
> > +static int log_store(u32 caller_id, int facility, int level,
> > enum log_flags flags, u64 ts_nsec,
> > const char *dict, u16 dict_len,
> > const char *text, u16 text_len)
>
> I counted nine.
>
> Dunno, we might want to just create a dummy struct and pass it
> around, instead of doing
>
> vprintk_emit (6 params)
> vprintk_store (6 params)
> log_output (7 params)
> log_store (9 params)

Yeah, it would make sense. I still dream about a bigger printk
code clean up. But let's see what comes from the realtime-related
patchset first.

Anyway, thanks for review.

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-02-21 10:32    [W:0.047 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site