lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3] usb: chipidea: Grab the (legacy) USB PHY by phandle first
Date

> > Current code w/o your patch, it is possible both ci->phy and
> > ci->usb_phy are valid if the USB PHY is not at the device tree, but generic PHY is
> at the device tree.
> > If you don't want to fix this issue with this patch, it is ok too. We could fix it later.
>
> I'm not sure I understand the issue. With my patch, if there is a generic PHY
> described in device-tree, then devm_usb_get_phy_by_phandle for legacy PHY will
> fail and the code will fallback to devm_usb_get_phy, which is the same behavior as
> before.
>

You are right, but this behavior is incorrect since each controller has only one physical
USB PHY.

> Is it a problem that we can end up with both a generic and legacy PHY?
> I thought this was expected behavior at probe, and the rest of the code will just use
> the generic one in priority.
>
> Do you want to make it so that only one (generic or legacy) PHY remains after
> probe?
>

Yes, I just want only one valid, either ci->phy or ci->usb_phy, it makes sense.

Peter

\
 
 \ /
  Last update: 2019-02-21 10:32    [W:0.052 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site