lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv3] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters
    Hi Guenther,

    On Wed, 20 Feb 2019, Guenter Roeck wrote:
    > On 2/20/19 7:11 AM, Nikolaus Voss wrote:
    >> From: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
    >>
    >> Commit 1a2f474d328f handles block _reads_ separately with plain-I2C
    >> adapters, but the problem described with regmap-i2c not handling
    >> SMBus block transfers (i.e. read and writes) correctly also exists
    >> with writes.
    >>
    >> As workaround, this patch adds a block write function the same way
    >> 1a2f474d328f adds a block read function.
    >>
    >> Fixes: 1a2f474d328f ("usb: typec: tps6598x: handle block reads separately
    >> with plain-I2C adapters")
    >> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery
    >> controllers")
    >> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
    >
    > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    >
    > Note that tps6598x_exec_cmd() is only called with in_len == out_len == 0
    > and NULL data pointers.

    That's probably why I didn't notice I missed patching tps6598x_exec_cmd()
    in spite of running and testing the driver for half a year ;-).

    Thanks,
    Nikolaus

    \
     
     \ /
      Last update: 2019-02-21 09:42    [W:6.394 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site