Messages in this thread | | | From | Kees Cook <> | Date | Thu, 21 Feb 2019 15:16:14 -0800 | Subject | Re: [PATCH 5/6] lib: Fix function documentation for strncpy_from_user |
| |
On Thu, Feb 21, 2019 at 12:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > Hi Kees, > > On Wed, 20 Feb 2019 22:02:32 -0800 Kees Cook <keescook@chromium.org> wrote: > > > > What I can't quite figure out yet is how to find a way for sfr to flag > > newly added users of strcpy, strncpy, and strlcpy. We might need to > > bring back __deprecated, but hide it behind a W=linux-next flag or > > something crazy. Stephen, in your builds you're already injecting > > -Wimplicit-fallthrough: do you do W=1 or anything like that? If not, I > > think we need some W= setting for your linux-next builds that generate > > the maintainer-nag warnings... > > I just have a set of compiler flags that my build scripts explicitly > enable by setting KCFLAGS.
Okay, so you could include some -D option to enable it. I'll see if I can cook something up.
-- Kees Cook
| |