lkml.org 
[lkml]   [2019]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] IB/hfi1: Add missing break in switch statement
From
Date


On 2/21/19 3:09 PM, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 07:02:33PM -0600, Gustavo A. R. Silva wrote:
>> Fix the following warning by adding a missing break:
>>
>> drivers/infiniband/hw/hfi1/tid_rdma.c: In function ‘hfi1_tid_rdma_wqe_interlock’:
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3251:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> switch (prev->wr.opcode) {
>> ^~~~~~
>> drivers/infiniband/hw/hfi1/tid_rdma.c:3259:2: note: here
>> case IB_WR_RDMA_READ:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: c6c231175ccd ("IB/hfi1: Add interlock between TID RDMA WRITE and other requests")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Reviewed-by: Kaike Wan <Kaike.wan@intel.com>
>> --
>> drivers/infiniband/hw/hfi1/tid_rdma.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Applied to for-next, thanks
>

Great. :)

Thank you both, Kaike and Jason.

--
Gustavo

\
 
 \ /
  Last update: 2019-02-21 22:26    [W:0.063 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site