Messages in this thread | | | From | <> | Subject | Re: [PATCH] mtd: spi-nor: Add Winbond w25q16jv support | Date | Wed, 20 Feb 2019 20:29:07 +0000 |
| |
Hi, Robert,
On 02/14/2019 10:57 PM, Robert Marko wrote: > Datasheet: https://www.winbond.com/resource-files/w25q16jv%20spi%20revg%2003222018%20plus.pdf > > Testing done on Mikrotik Routerboard RB450Gx4 board under 4.19.19 kernel.
It is preferable to do the test on spi-nor/next > > Test board does not support Dual or Quad modes. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 6e13bbd1aaa5..0e958f48db1b 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1975,6 +1975,11 @@ static const struct flash_info spi_nor_ids[] = { > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > }, > + { > + "w25q16jv", INFO(0xef7015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
You'll need a way to differentiate between W25Q16JV-IQ/JQ and W25Q16JV-IM/JM.
And I would prefer to have the new entries ordered alphabetically as much as possible. This one should fit just before w25q20cl. Manufacturers are naming flashes based on a product identification system. The flashes are presented in alphabetical order, we should do the same.
Cheers, ta
| |