lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[for-next][PATCH 04/29] tracing: Add comment to predicate_parse() about "&&" or "||"
    From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

    As the predicat_parse() code is rather complex, commenting subtleties is
    important. The switch case statement should be commented to describe that it
    is only looking for two '&' or '|' together, which is why the fall through
    to an error is after the check.

    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
    ---
    kernel/trace/trace_events_filter.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
    index eb694756c4bb..f052ecb085e9 100644
    --- a/kernel/trace/trace_events_filter.c
    +++ b/kernel/trace/trace_events_filter.c
    @@ -491,6 +491,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds,
    break;
    case '&':
    case '|':
    + /* accepting only "&&" or "||" */
    if (next[1] == next[0]) {
    ptr++;
    break;
    --
    2.20.1

    \
     
     \ /
      Last update: 2019-02-20 19:40    [W:2.682 / U:0.528 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site