Messages in this thread Patch in this message | | | Date | Wed, 20 Feb 2019 13:37:41 -0500 | From | Steven Rostedt <> | Subject | [for-next][PATCH 04/29] tracing: Add comment to predicate_parse() about "&&" or "||" |
| |
From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
As the predicat_parse() code is rather complex, commenting subtleties is important. The switch case statement should be commented to describe that it is only looking for two '&' or '|' together, which is why the fall through to an error is after the check.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> --- kernel/trace/trace_events_filter.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index eb694756c4bb..f052ecb085e9 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -491,6 +491,7 @@ predicate_parse(const char *str, int nr_parens, int nr_preds, break; case '&': case '|': + /* accepting only "&&" or "||" */ if (next[1] == next[0]) { ptr++; break; -- 2.20.1
| |