lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/9] iio: accel: bma180: convert to devm
From
Date

> Am 20.02.2019 um 17:09 schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> On Wed, Feb 20, 2019 at 03:00:52PM +0100, H. Nikolaus Schaller wrote:
>> This simplifies the code a little.
>
>> -err_buffer_cleanup:
>> - iio_triggered_buffer_cleanup(indio_dev);
>> -err_trigger_unregister:
>> - if (data->trig)
>> - iio_trigger_unregister(data->trig);
>> -err_trigger_free:
>> - iio_trigger_free(data->trig);
>
>> -err_chip_disable:
>> +err:
>
> Please, leave the original label name as it's more self-explanatory.

Ok.

>
>> data->part_info->chip_disable(data);
>>
>> return ret;
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

\
 
 \ /
  Last update: 2019-02-20 17:15    [W:0.091 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site