lkml.org 
[lkml]   [2019]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc: Move page table dump files in a dedicated subdirectory
From
Date


Le 20/02/2019 à 14:37, Michael Ellerman a écrit :
> Christophe Leroy <christophe.leroy@c-s.fr> writes:
>
>> This patch moves the files related to page table dump in a
>> dedicated subdirectory.
>>
>> The purpose is to clean a bit arch/powerpc/mm by regrouping
>> multiple files handling a dedicated function.
>>
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>> ---
>> arch/powerpc/Kconfig.debug | 4 ----
>> arch/powerpc/mm/Makefile | 10 +---------
>> arch/powerpc/mm/ptdump/Makefile | 9 +++++++++
>> arch/powerpc/mm/{ => ptdump}/dump_bats.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c | 0
>> arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h | 0
>> arch/powerpc/mm/{ => ptdump}/dump_sr.c | 0
>> 11 files changed, 10 insertions(+), 13 deletions(-)
>> create mode 100644 arch/powerpc/mm/ptdump/Makefile
>> rename arch/powerpc/mm/{ => ptdump}/dump_bats.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_hashpagetable.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-8xx.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-book3s64.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables-generic.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.c (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_linuxpagetables.h (100%)
>> rename arch/powerpc/mm/{ => ptdump}/dump_sr.c (100%)
>
> I'd like to shorten the file names as well, now that they're namespaced
> in the ptdump directory, how about:
>
> arch/powerpc/Kconfig.debug | 4 ----
> arch/powerpc/mm/Makefile | 10 +---------
> arch/powerpc/mm/{dump_linuxpagetables-8xx.c => ptdump/8xx.c} | 2 +-
> arch/powerpc/mm/ptdump/Makefile | 9 +++++++++
> arch/powerpc/mm/{dump_bats.c => ptdump/bats.c} | 0
> arch/powerpc/mm/{dump_linuxpagetables-book3s64.c => ptdump/book3s64.c} | 2 +-
> arch/powerpc/mm/{dump_hashpagetable.c => ptdump/hashpagetable.c} | 0
> arch/powerpc/mm/{dump_linuxpagetables.c => ptdump/ptdump.c} | 2 +-
> arch/powerpc/mm/{dump_linuxpagetables.h => ptdump/ptdump.h} | 0
> arch/powerpc/mm/{dump_sr.c => ptdump/segment_regs.c} | 0
> arch/powerpc/mm/{dump_linuxpagetables-generic.c => ptdump/shared.c} | 2 +-

Yes good idea. Do you want a v2 or will you do it ?

Christophe

>
>
> cheers
>

\
 
 \ /
  Last update: 2019-02-20 15:01    [W:0.047 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site