Messages in this thread | | | Subject | Re: [PATCH 06/13] mm: pagewalk: Add 'depth' parameter to pte_hole | From | William Kucharski <> | Date | Wed, 20 Feb 2019 04:35:11 -0700 |
| |
> On Feb 15, 2019, at 10:02 AM, Steven Price <Steven.Price@arm.com> wrote: > > The pte_hole() callback is called at multiple levels of the page tables. > Code dumping the kernel page tables needs to know what at what depth > the missing entry is. Add this is an extra parameter to pte_hole(). > When the depth isn't know (e.g. processing a vma) then -1 is passed. > > Note that depth starts at 0 for a PGD so that PUD/PMD/PTE retain their > natural numbers as levels 2/3/4.
Nit: Could you add a comment noting this for anyone wondering how to calculate the level numbers in the future?
Thanks!
| |