Messages in this thread | | | From | Linus Walleij <> | Date | Wed, 20 Feb 2019 10:57:03 +0100 | Subject | Re: [PATCH 1/2] drivers: provide devm_platform_ioremap_resource() |
| |
On Fri, Feb 15, 2019 at 4:25 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > There are currently 1200+ instances of using platform_get_resource() > and devm_ioremap_resource() together in the kernel tree. > > This patch wraps these two calls in a single helper. Thanks to that > we don't have to declare a local variable for struct resource * and can > omit the redundant argument for resource type. We also have one > function call less. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
This makes a lot of sense. I think Andy can confirm the value, he knows a lot about good helpers.
I'd need Greg's ACK on this before merging through GPIO.
Can we make a script or coccinelle thing to fix them all when this is applied?
Yours, Linus Walleij
| |