Messages in this thread | | | Date | Sat, 2 Feb 2019 14:30:50 -0500 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 4.19 059/258] x86/resctrl: Fixup the user-visible strings |
| |
On Mon, Jan 28, 2019 at 11:07:34AM -0800, Reinette Chatre wrote: >Hi Sasha, > >On 1/28/2019 7:56 AM, Sasha Levin wrote: >> From: Babu Moger <Babu.Moger@amd.com> >> >> [ Upstream commit 723f1a0dd8e26a7523ba068204bee11c95ded38d ] >> >> Fix the messages in rdt_last_cmd_printf() and rdt_last_cmd_puts() to >> make them more meaningful and consistent. > >It is not clear to me why this patch is considered for stable since it >just changes user visible strings to be more consistent. > >If user visible string consistency/correctness is of concern and is what >prompted its consideration then please also consider to include upstream >commit >456824896de2b68df40b3ea5777ef49dc6cc8fda "x86/resctrl: Use >rdt_last_cmd_puts() where possible" that fixes two typos that was >introduced in this commit. This may introduce difficultly though since >the file layout changed between the kernel versions these patches are >found in.
I've dropped it, it shouldn't have been included to begin with.
-- Thanks, Sasha
| |