lkml.org 
[lkml]   [2019]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC v4 02/17] kunit: test: add test resource management API
    On Fri, Feb 15, 2019 at 1:01 PM Stephen Boyd <sboyd@kernel.org> wrote:
    >
    > Quoting Brendan Higgins (2019-02-14 13:37:14)
    > > @@ -104,6 +167,7 @@ struct kunit {
    > > const char *name; /* Read only after initialization! */
    > > spinlock_t lock; /* Gaurds all mutable test state. */
    > > bool success; /* Protected by lock. */
    > > + struct list_head resources; /* Protected by lock. */
    > > void (*vprintk)(const struct kunit *test,
    > > const char *level,
    > > struct va_format *vaf);
    > > @@ -127,6 +191,51 @@ int kunit_run_tests(struct kunit_module *module);
    > > } \
    > > late_initcall(module_kunit_init##module)
    > >
    > > +/**
    > > + * kunit_alloc_resource() - Allocates a *test managed resource*.
    > > + * @test: The test context object.
    > > + * @init: a user supplied function to initialize the resource.
    > > + * @free: a user supplied function to free the resource.
    > > + * @context: for the user to pass in arbitrary data.
    >
    > Nitpick: "pass in arbitrary data to the init function"? Maybe that
    > provides some more clarity.

    I think that makes sense. Will fix in next revision.

    \
     
     \ /
      Last update: 2019-02-20 00:25    [W:5.169 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site