Messages in this thread | | | Subject | Re: [PATCH] drm/amd/powerplay/smu10_hwmgr: use struct_size() in kzalloc() | From | "Gustavo A. R. Silva" <> | Date | Tue, 19 Feb 2019 14:08:26 -0600 |
| |
On 2/19/19 1:51 PM, Alex Deucher wrote: > On Tue, Feb 19, 2019 at 1:55 PM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> One of the more common cases of allocation size calculations is finding >> the size of a structure that has a zero-sized array at the end, along >> with memory for some number of elements for that array. For example: >> >> struct foo { >> int stuff; >> struct boo entry[]; >> }; >> >> size = sizeof(struct foo) + count * sizeof(struct boo); >> instance = kzalloc(size, GFP_KERNEL); >> >> Instead of leaving these open-coded and prone to type mistakes, we can >> now use the new struct_size() helper: >> >> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); >> >> Notice that, in this case, variable table_size is not necessary, hence >> it is removed. >> >> This code was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied this and the smu8 patch. Thanks! > Great!
Thanks, Alex.
-- Gustavo
| |